Simplify Lighthouse CI workflow by removing GitHub CLI setup#2
Merged
Conversation
Remove the "Setup GitHub CLI" and "Authenticate GitHub CLI" steps that are not used by the working deploy and validate workflows. Remove the LHCI_GITHUB_APP_TOKEN env var which references a non-existent secret. The gh CLI is pre-installed on ubuntu-latest and automatically uses the GH_TOKEN env var — no explicit gh auth login is needed, matching the pattern used by deploy.yml and validate.yml. https://claude.ai/code/session_01U1HYSJ2cRcy99YsBjfjqgd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the Lighthouse CI GitHub Actions workflow by removing unnecessary GitHub CLI installation and authentication steps.
Key Changes
LHCI_GITHUB_APP_TOKENsecret from the Lighthouse CI environment variablesGH_TOKENenvironment variable for the Lighthouse CI stepDetails
The GitHub CLI setup and authentication were not being used by the
bun run test:lighthousecommand, making them unnecessary overhead in the workflow. This change reduces workflow complexity and execution time by eliminating redundant installation and authentication steps while maintaining the required token access for Lighthouse CI operations.https://claude.ai/code/session_01U1HYSJ2cRcy99YsBjfjqgd